Commit graph

17 commits

Author SHA1 Message Date
infinite-persistence
0143b63c74 Ads: replace DOM manipulations with React components
- Instead of 2 ways to display ads (DOM injection + React method) and having both of them clash, just do it the predictable React way.
    - Augment the existing React version to support tile layout + ability to place in last visible slot.
    - Consolidate styling code to scss ... DOM manipulations were making it even harder to maintain.
    - Removed the need to check for ad-blockers for now. It was being executed every time an ad is displayed, and now that we are displaying ads in more places, the gains doesn't justify the performance loss. Also, it wasn't being done for Recommended ads anyway, so the inconsistency probably means it's not needed in the first place.

Other known issues fixed:
- double ad injection when changing language via nag.
- additional "total-blocking-time" due to ads at startup removed.
- fixed ads not appearing in mobile homepage until navigated away and back to homepage.
- enable ads in channel page.
- support for both List and Tile layout.
2022-03-08 10:53:52 -05:00
infinite-persistence
1b0b9cad94 Cleanup ad container css
- Non hardcoded way to reserve space.
- Replace hardcoded margin.
2022-03-08 10:53:52 -05:00
mayeaux
0c4f85fe53
MAKE ODYSEE EVEN MORE BEAUTIFUL (#539)
WE LOVE YOU RAPHAEL FOR MAKING THIS HAPPEN!
2022-02-11 13:50:55 -05:00
mayeaux
58bdcbd1ed
Reduce triple call to single call, improve video loading, fix embed play button being off-center (#546)
Lots of optimizations and cleanup for the player. If we run into any strange issues, can revert.
2022-01-06 14:28:27 -05:00
infinite-persistence
c62c667436
CLS: reserve space for injected video ads 2021-07-23 13:23:51 +08:00
DispatchCommit
14d9b99c7b hide logo image on sidebar ads 2021-07-07 18:37:34 -07:00
zeppi
6d8fce6011 remove more google 2021-06-23 08:54:19 -04:00
zeppi
870b9e0c27 wip 2021-04-27 11:20:41 -04:00
Sean Yesmunt
e08b71774c pre-roll ads 2021-04-12 12:55:06 -04:00
zeppi
61ace3566a gads on master 2021-01-23 12:57:09 -05:00
jessop
fab03d337e ad fix 2 2020-10-21 15:30:01 -04:00
jessop
2f84d94c66 related add full width 2020-10-19 22:59:24 -04:00
Sean Yesmunt
e7cdd6c13d moonpay 2020-06-03 14:16:43 -04:00
Sean Yesmunt
f7846e976a style cleanup 2020-03-30 09:40:10 -04:00
Sean Yesmunt
c4fc2993d5 initial commit for inline video ads 2020-03-30 09:40:10 -04:00
Sean Yesmunt
9655c527f4 add background color to ads and fix dark mode style 2020-01-24 14:26:37 -05:00
Sean Yesmunt
b4564c6f46 add message to ads about signing in 2020-01-24 14:26:37 -05:00