LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Dark #1269

Merged
btzr-io merged 4 commits from dark into master 2018-04-17 08:32:42 +02:00
Conversation 8 Commits 4 Files changed 17 +209 -133
btzr-io commented 2018-04-03 23:56:49 +02:00 (Migrated from github.com)
Copy link

Changes

Fixes

  • Download percentage indicator overlay #1271
  • Fix dark theme: #1034
## Changes <img src=https://img00.deviantart.net/b04a/i/2016/092/3/9/join_the_dark_side_darth_vader_flag_by_osflag-d9xe8up.jpg > ## Fixes - Download percentage indicator overlay #1271 - Fix dark theme: #1034
🎉 1
btzr-io commented 2018-04-04 00:01:35 +02:00 (Migrated from github.com)
Copy link

Fix dark theme: https://github.com/lbryio/lbry-app/issues/1034

Fix dark theme: https://github.com/lbryio/lbry-app/issues/1034
neb-b (Migrated from github.com) requested changes 2018-04-04 03:08:24 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Great start. Some of the dark mode colors changed with the new design.
Checkout http://lbry.zzk.fr to see the new colors 🙂

Great start. Some of the dark mode colors changed with the new design. Checkout http://lbry.zzk.fr to see the new colors 🙂
src/renderer/scss/_gui.scss
neb-b (Migrated from github.com) commented 2018-04-04 03:06:42 +02:00
Copy link

The dashed/dotted should stay the same

The `dashed`/`dotted` should stay the same
btzr-io commented 2018-04-04 06:52:46 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt I added the new colors as an additional theme -> blueberry,
so now there are three themes: light, dark and blueberry

@seanyesmunt I added the new colors as an additional theme -> `blueberry`, so now there are three themes: `light, dark and blueberry`
btzr-io commented 2018-04-04 23:17:19 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt Ready for the next review

@seanyesmunt Ready for the next review
tzarebczan commented 2018-04-05 23:34:22 +02:00 (Migrated from github.com)
Copy link

@btzr-io not sure if we want to maintain 3 themes going forward, but I'll let @seanyesmunt make the call.

Will give this a shot later tonight/tomorrow.

@btzr-io not sure if we want to maintain 3 themes going forward, but I'll let @seanyesmunt make the call. Will give this a shot later tonight/tomorrow.
neb-b (Migrated from github.com) requested changes 2018-04-10 22:11:24 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

@btzr-io Sorry it took so long for me to took at this.

I agree with Tom. I think at first we just want to release the "blueberry" theme (but call it dark theme).

The main issue I see is the buttons and the dropdowns (dropdown styling should probably be it's own issue).

The only button that is purple is the publish button. Everything else is still the same green. Also the forward/back needs hover styling.

@btzr-io Sorry it took so long for me to took at this. I agree with Tom. I think at first we just want to release the "blueberry" theme (but call it dark theme). The main issue I see is the buttons and the dropdowns (dropdown styling should probably be it's own issue). The only button that is purple is the publish button. Everything else is still the same green. Also the forward/back needs hover styling.
btzr-io commented 2018-04-12 01:45:30 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt Ok, it's done.

Dropdown styling should probably be it's own issue

This should be handle after merging: https://github.com/lbryio/lbry-app/issues/1317

@seanyesmunt Ok, it's done. > Dropdown styling should probably be it's own issue This should be handle after merging: https://github.com/lbryio/lbry-app/issues/1317
neb-b (Migrated from github.com) requested changes 2018-04-12 19:35:03 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Left a few more comments.

Ideally we would have 0 !important uses in our styles. I know that might not be possible, but in most cases we can avoid them with class names or removing the styles that we want to override.

Left a few more comments. Ideally we would have 0 `!important` uses in our styles. I know that might not be possible, but in most cases we can avoid them with class names or removing the styles that we want to override.
src/renderer/scss/_gui.scss
neb-b (Migrated from github.com) commented 2018-04-12 19:25:02 +02:00
Copy link

This shouldn't change. It should be a border on every side

This shouldn't change. It should be a border on every side
neb-b (Migrated from github.com) commented 2018-04-12 19:26:38 +02:00
Copy link

This isn't the correct style. We shouldn't need to change anything here.

This isn't the correct style. We shouldn't need to change anything here.
src/renderer/scss/_gui.scss
@ -107,6 +110,7 @@ input {
}
input::placeholder {
color: var(--input-placeholder-color);
neb-b (Migrated from github.com) commented 2018-04-12 19:28:56 +02:00
Copy link

We shouldn't need an !important here. If there is something that is overriding this style, we should remove that, or make this a more specific rule with classnames

We shouldn't need an `!important` here. If there is something that is overriding this style, we should remove that, or make this a more specific rule with classnames
src/renderer/scss/component/_modal.scss
neb-b (Migrated from github.com) commented 2018-04-12 19:31:00 +02:00
Copy link

Do we need this? It doesn't look like it's doing anything. We should set any variables in vars.scss

Do we need this? It doesn't look like it's doing anything. We should set any variables in `vars.scss`
src/renderer/scss/component/_search.scss
neb-b (Migrated from github.com) commented 2018-04-12 19:33:26 +02:00
Copy link

Can we not use ::placeholder here?

Can we not use `::placeholder` here?
btzr-io (Migrated from github.com) reviewed 2018-04-12 20:23:11 +02:00
src/renderer/scss/component/_modal.scss
btzr-io (Migrated from github.com) commented 2018-04-12 20:23:11 +02:00
Copy link

this overwrites the btn-alt background color inside modal, remove this line and open a modal with the dark theme selected, the button an background of the modal use the same color so is hard to see it.

this overwrites the `btn-alt` background color inside modal, remove this line and open a modal with the dark theme selected, the button an background of the modal use the same color so is hard to see it.
btzr-io (Migrated from github.com) reviewed 2018-04-12 20:53:50 +02:00
src/renderer/scss/component/_modal.scss
@ -40,7 +44,7 @@
right: 0;
bottom: 0;
btzr-io (Migrated from github.com) commented 2018-04-12 20:53:43 +02:00
Copy link

@seanyesmunt Not sure if this is the right way to do this, but I don't have time to add a new class to all btn-alt used inside the modal component 😛

@seanyesmunt Not sure if this is the right way to do this, but I don't have time to add a new class to all `btn-alt` used inside the modal component :stuck_out_tongue:
btzr-io (Migrated from github.com) reviewed 2018-04-12 23:14:31 +02:00
src/renderer/scss/_gui.scss
btzr-io (Migrated from github.com) commented 2018-04-12 23:14:31 +02:00
Copy link

Not sure why I did that 🙃

Not sure why I did that :upside_down_face:
neb-b (Migrated from github.com) reviewed 2018-04-17 00:18:06 +02:00
src/renderer/scss/component/_modal.scss
@ -40,7 +44,7 @@
right: 0;
bottom: 0;
neb-b (Migrated from github.com) commented 2018-04-17 00:18:06 +02:00
Copy link

I think this is ok for now.

I think this is ok for now.
neb-b (Migrated from github.com) reviewed 2018-04-17 00:18:31 +02:00
src/renderer/scss/component/_modal.scss
@ -40,7 +44,7 @@
right: 0;
bottom: 0;
neb-b (Migrated from github.com) commented 2018-04-17 00:18:31 +02:00
Copy link

Well, do modals in dark mode not use the regular alt button style?

Well, do modals in dark mode not use the regular alt button style?
neb-b commented 2018-04-17 00:18:35 +02:00 (Migrated from github.com)
Copy link

I totally messed up the number of commits. Could you squash?

I think the only two issues I still see are that we lost the background-color for the text-copyable used in the address and file selector. And the "You have {lbc}" doesn't change color on hover.

I totally messed up the number of commits. Could you squash? I think the only two issues I still see are that we lost the background-color for the `text-copyable` used in the address and file selector. And the "You have {lbc}" doesn't change color on hover.
👍 1
btzr-io (Migrated from github.com) reviewed 2018-04-17 03:45:45 +02:00
src/renderer/scss/component/_modal.scss
@ -40,7 +44,7 @@
right: 0;
bottom: 0;
btzr-io (Migrated from github.com) commented 2018-04-17 03:45:45 +02:00
Copy link

@seanyesmunt yes but it's the same color as the background of the modal 🙃,
see: https://design.lbry.io

@seanyesmunt yes but it's the same color as the background of the modal :upside_down_face:, see: https://design.lbry.io
neb-b commented 2018-04-17 03:47:55 +02:00 (Migrated from github.com)
Copy link

Ahh gotcha

Ahh gotcha
btzr-io commented 2018-04-17 04:26:08 +02:00 (Migrated from github.com)
Copy link

Fix conflicts: a00f4eb

Fix conflicts: a00f4eb
neb-b (Migrated from github.com) approved these changes 2018-04-17 08:29:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#1269
No description provided.
Delete branch "dark"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?