fix reward error notification #1562

Merged

daovist merged 1 commit from reward-claim-silent-failure into master

2018-06-11 03:49:55 +02:00

daovist commented

2018-06-07 16:55:21 +02:00

(Migrated from github.com)

Fixes #1555 @tzarebczan

This adds an option parameter to doClaimRewardType which it uses to fail silently.

doClaimEligiblePurchaseRewards (called by each doDownloadFile) uses this option when attempting to claim rewards.TYPE_MANY_DOWNLOADS and rewards.TYPE_FEATURED_DOWNLOAD

The error modal for rewards is in the <RewardLink> component and displayed when errorMessage is defined. It was getting set in redux and sitting there until a <RewardLink> is rendered when a user visits the rewards page. error is sent undefined in this PR because not calling the error reducer results in the two rewards pending on the rewards page.

Fixes #1555 @tzarebczan This adds an `option` parameter to `doClaimRewardType` which it uses to fail silently. `doClaimEligiblePurchaseRewards` (called by each `doDownloadFile`) uses this option when attempting to claim `rewards.TYPE_MANY_DOWNLOADS` and `rewards.TYPE_FEATURED_DOWNLOAD` The error modal for rewards is in the `<RewardLink>` component and displayed when `errorMessage` is defined. It was getting set in redux and sitting there until a `<RewardLink>` is rendered when a user visits the rewards page. `error` is sent `undefined` in this PR because not calling the error reducer results in the two rewards pending on the rewards page.

tzarebczan commented

2018-06-08 17:40:39 +02:00

(Migrated from github.com)

Tested and it looks good now - no more error when going to the rewards page after streaming something.

neb-b commented

2018-06-08 21:39:54 +02:00

(Migrated from github.com)

I guess I'm not fully following the description of this. Why do we want this to fail silently? Shouldn't it just not fail?

kauffj commented

2018-06-08 21:44:37 +02:00

(Migrated from github.com)

@seanyesmunt some rewards that are checked automatically on all file starts ought to silently fail (e.g. we check for "many downloads" after every start until you've started enough).

neb-b (Migrated from github.com) approved these changes 2018-06-11 03:49:28 +02:00