Escape link for tags #2984

Merged

ksami merged 3 commits from ksami-patch-1 into master

2019-10-08 15:46:24 +02:00

ksami commented

2019-10-05 09:45:37 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #2678

Escapes the generated link for tags by using encodeURIComponent

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2678 Escapes the generated link for tags by using `encodeURIComponent`

neb-b commented

2019-10-06 03:26:50 +02:00

(Migrated from github.com)

Thanks for the pr!!

I'll give this a closer look soon but it looks good.

Thanks for the pr!! I'll give this a closer look soon but it looks good.

neb-b (Migrated from github.com) requested changes 2019-10-07 04:30:51 +02:00

neb-b (Migrated from github.com) left a comment

One small change. Can you also add an addition to this file?
https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md

One small change. Can you also add an addition to this file? https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md

src/ui/component/tag/view.jsx

neb-b (Migrated from github.com) commented

2019-10-07 04:29:51 +02:00

This should only wrap the name variable so the routing still works. Can you change this to

{ navigate: `/$/tags?t=${encodeURIComponent(name)}` };

This should only wrap the `name` variable so the routing still works. Can you change this to ``` { navigate: `/$/tags?t=${encodeURIComponent(name)}` }; ```

ksami (Migrated from github.com) reviewed 2019-10-07 17:15:27 +02:00

src/ui/component/tag/view.jsx

ksami (Migrated from github.com) commented

2019-10-07 17:15:27 +02:00

Oof sorry about that, I've fixed it. Also updated the changelog

neb-b commented

2019-10-08 15:46:48 +02:00

(Migrated from github.com)

Merged! Thanks again for the PR!

ksami commented

2019-10-08 15:59:09 +02:00

(Migrated from github.com)

Thanks for the guidance and being patient!

tzarebczan commented

2019-10-15 16:20:07 +02:00

(Migrated from github.com)

@ksami , thanks for the PR!

Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

@ksami , thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.