[Feature] keyboard shortcuts for Fullscreen, mute, volume & Seeking #2999

Merged

pankajpatel merged 2 commits from play-pause-keyboard into master

2019-10-08 17:33:24 +02:00

pankajpatel commented

2019-10-08 10:14:45 +02:00

(Migrated from github.com)

feat(shortcuts): keyboard shortcuts for Fullscreen, mute, volume and seeking

PR Checklist

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

Feature

Fixes

Issue Number: #2879

What is the current behavior?

No keyboard shortcuts for Fullscreen, Mute/unmute, Volume Up/Down and Seeking

What is the new behavior?

Added following keyboard shortcuts, similar to youtube player

f - Fullscreen
m - Mute/unmute
↑ - Volume Up
↓ - Volume Down
→ - Seek Forward
← - Seek Backward

**feat(shortcuts): keyboard shortcuts for Fullscreen, mute, volume and seeking** ## PR Checklist - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change ## PR Type What kind of change does this PR introduce? - [x] Feature ## Fixes Issue Number: #2879 ## What is the current behavior? No keyboard shortcuts for Fullscreen, Mute/unmute, Volume Up/Down and Seeking ## What is the new behavior? Added following keyboard shortcuts, similar to youtube player - `f` - Fullscreen - `m` - Mute/unmute - `↑` - Volume Up - `↓` - Volume Down - `→` - Seek Forward - `←` - Seek Backward

neb-b (Migrated from github.com) requested changes 2019-10-08 15:53:25 +02:00

neb-b (Migrated from github.com) left a comment

This is great!!

I think we should remove the volume change shortcuts (since up/down already can handle scroll). Everything else looks good. Can you also add an entry to here:
https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md

This is great!! I think we should remove the volume change shortcuts (since up/down already can handle scroll). Everything else looks good. Can you also add an entry to here: https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md

src/ui/component/viewers/videoViewer/view.jsx

neb-b (Migrated from github.com) commented

2019-10-08 15:52:20 +02:00

I don't think we need the volume change on up/down

pankajpatel (Migrated from github.com) reviewed 2019-10-08 17:21:54 +02:00

src/ui/component/viewers/videoViewer/view.jsx

pankajpatel (Migrated from github.com) commented

2019-10-08 17:21:53 +02:00

removed the volume shortcuts
updated the CHANGELOG

- removed the volume shortcuts - updated the CHANGELOG

pankajpatel commented

2019-10-08 17:22:37 +02:00

(Migrated from github.com)

@seanyesmunt Thanks for the review; I have updated the MR incorporating the suggested changes

neb-b commented

2019-10-08 17:33:18 +02:00

(Migrated from github.com)

Awesome!

❤️ 1 🎉 1

tzarebczan commented

2019-10-15 16:22:28 +02:00

(Migrated from github.com)

@pankajpatel, thanks for the PR!

Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

@pankajpatel, thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.