Fix gap between video player and background #3037

Merged

btzr-io merged 4 commits from gap into master

2019-10-15 19:24:45 +02:00

btzr-io commented

2019-10-13 23:47:12 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Fix gap between video player and background #3025

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Fix gap between video player and background #3025

btzr-io commented

2019-10-13 23:48:47 +02:00

(Migrated from github.com)

Still need to test this on a different pc or monitor.
For some reason I cant reproduce this on my current pc 🙃

Still need to test this on a different pc or monitor. For some reason I cant reproduce this on my current pc :upside_down_face:

neb-b commented

2019-10-14 16:26:18 +02:00

(Migrated from github.com)

I haven't been able to reproduce this bug on my computer so I'm not sure if this fixes it. @tzarebczan Could you test this?

tzarebczan commented

2019-10-14 16:36:27 +02:00

(Migrated from github.com)

Yep, seems to fix it here! Nice job @btzr-io

👍 1

btzr-io commented

2019-10-14 19:11:41 +02:00

(Migrated from github.com)

@seanyesmunt I also tested on another computer but wasn't sure it worked on all cases.

tzarebczan commented

2019-10-15 16:16:40 +02:00

(Migrated from github.com)

@btzr-io, thanks for the PR! Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

@btzr-io, thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.