Add Confirmation when sending Tip/Support #4051

Merged

jeffslofish merged 3 commits from issue-2714 into master

2020-04-29 19:28:12 +02:00

jeffslofish commented

2020-04-23 10:25:28 +02:00

(Migrated from github.com)

Closes #2714

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #2714

What is the current behavior?

When tipping or adding support, the tip/support happens immediately when you click the send button.

What is the new behavior?

When tipping or adding support a confirmation modal appears after clicking send. Clicking send on the confirmation modal will perform the tip/support.

Other information

Closes #2714 ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #2714 ## What is the current behavior? When tipping or adding support, the tip/support happens immediately when you click the send button. ## What is the new behavior? When tipping or adding support a confirmation modal appears after clicking send. Clicking send on the confirmation modal will perform the tip/support. ## Other information

kauffj commented

2020-04-23 16:06:19 +02:00

(Migrated from github.com)

I'd like to propose two changes to this:

Do not double confirm on supports. These are easy and cheap to undo.
Expand and rename the Purchase Confirmation setting in Settings to Purchase and Tip Confirmation. Respect this setting on whether to ask for a confirmation. This setting should also be made visible for lbry.tv users.

I'd like to propose two changes to this: 1. Do not double confirm on supports. These are easy and cheap to undo. 2. Expand and rename the Purchase Confirmation setting in Settings to Purchase and Tip Confirmation. Respect this setting on whether to ask for a confirmation. This setting should also be made visible for lbry.tv users.

neb-b (Migrated from github.com) requested changes

2020-04-23 17:09:31 +02:00