e9a2f44899
## General - `setting.List`: returns full creator settings. Requires signature (i.e. you own the channel) - `setting.Get`: returns a public subset of the creator settings. No signature required, and it is mainly used by the GUI to determine the constraints of a channel (e.g. comments enabled? min tip requirements? etc.). Does not include private settings like "blocked words list". `doFetchCreatorSettings` will handle both of these. Clients that uses the stashed results (`settingsByChannelId`) just needs to be aware the result might not contain everything, depending on whether you own the channel or not. ## Misc Related Changes - Finally fix the reducer for COMMENT_FETCH_SETTINGS_COMPLETED to not purge the data on each call. - Change `doFetchCreatorSettings` to operate on a single channel instead of multiple. We ended up not using the multple mode anyway, so it was wasteful code trying to batch the promises. - `commentsDisabledChannelIds` is no longer needed. Previously, this was created just to differentiate between Creator (full) and Channel (subset) settings. It's cleaner to just use one object, so eliminated this. - Remove unused 'commentingEnabled'. ## Aside - There are now 2 ways to know if a channel has disabled comments: (1) from `comment.list` and `setting.Get|List`. Both of them updates `settingsByChannelId`, so it'll still be a single place for the GUI to check against. |
||
|---|---|---|
| .. | ||
| autoLaunch.js | ||
| buildHomepage.js | ||
| claim.js | ||
| comments.js | ||
| context-menu.js | ||
| country.js | ||
| debounce.js | ||
| deep-equal.js | ||
| default-languages.js | ||
| detect-typing.js | ||
| downloadClaim.js | ||
| enhanced-layout.js | ||
| fetch.js | ||
| form-validation.js | ||
| format-bytes.js | ||
| formatAriaLabel.js | ||
| formatMediaDuration.js | ||
| full-screen.js | ||
| generate-thumbnail-name.js | ||
| handle-fetch.js | ||
| hex.js | ||
| lazyImport.js | ||
| number.js | ||
| object.js | ||
| parse-data.js | ||
| publish.js | ||
| query-params.js | ||
| redux-utils.js | ||
| remark-lbry.js | ||
| remark-timestamp.js | ||
| saved-passwords.js | ||
| search.js | ||
| set-operations.js | ||
| shuffle-array.js | ||
| string.js | ||
| swap-json.js | ||
| sync-settings.js | ||
| throttle.js | ||
| thumbnail.js | ||
| time.js | ||
| url.js | ||
| web-file-system.js | ||
| web.js | ||
| zoomWindow.js | ||