LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/page
History
infinite-persistence ce9a1c128c
Show-page: fix "no content found" flicker (#1546) 
* Show-page: split out some effects

Break apart the large effect for easier tweaking, abiding by the 1-action-per-effect guideline.

This also fixes the dependency list. After checking with Haffa, the exclusion of `pathname` and `hash` from the list is probably to avoid hitting `doResolveUri`. This should no longer be an issue after the split, so no suppression needed.

* Show-page: fix "no content found" flicker

## Issue
1539: "Recently been seeing a flicker of "content not found" when direct loading content or channel links on mobile"

## Cause
`doResolveUri` can only be called after the initial mount (in the effect), so at first render, `isResolvingUri` won't be set yet, so we briefly ended up in the "no content found" path.

## Change
Factor out the logic that determines if we should send `doResolveUri`. This allows us to know that the upcoming effect will be sending `doResolveUri`, so we can hold off displaying "no content found".

* Show-page: don't delay the spinner when resolving

## Reason
The delay causes a blank page + footer, which looks bad.
2022-05-24 06:39:21 -04:00
..
backup add wallet sync message on wallet page 2020-02-21 13:42:17 -05:00
buy Fix incorrect usages of I18nMessage 2022-02-18 20:00:36 +08:00
channel OptimizedImage: clean up attribute removal 2022-03-25 10:54:18 +08:00
channelNew Limit channel-creation count from the UI (#886) 2022-02-16 09:14:08 -05:00
channels String change 2022-05-05 11:24:22 -04:00
channelsFollowing Following Page: fix redundant livestream data passed in 2022-03-21 15:03:47 +08:00
channelsFollowingDiscover MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
channelsFollowingManage ClaimList: Factor out infinite-scroll and batch-resolve handling into an effect. 2022-05-16 07:57:24 -04:00
checkoutPage Revert "move stuff to web (#6537)" 2021-07-19 10:12:57 -04:00
collection Add requested review changes 2022-05-05 09:42:24 -04:00
creatorDashboard Add channel selector on HeaderMenuButton 2022-05-05 11:24:22 -04:00
discover Grid patch v1 (#1555) 2022-05-23 11:32:57 +02:00
embedWrapper Fix selector naming convention 2022-05-19 13:10:37 +08:00
file Remove clearPosition functions for playlists (#1560) 2022-05-24 06:07:46 -04:00
fileListDownloaded Re-enable 'Purchases' page 2022-04-07 14:28:12 -04:00
fileListPublished Uploads Page: fix Repost tab when count is 0 2022-04-05 12:47:47 -04:00
fourOhFour Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
help Add "What's New" button in the Help Page 2022-05-20 00:04:07 +08:00
home Remove Premium+ Tiles when Premium+ is active (#1525) 2022-05-18 20:51:15 +02:00
invite Defer user/invite_status from startup 2022-01-21 09:19:17 -05:00
invited Fix url selectors 2021-11-17 19:57:04 +08:00
library Re-enable 'Purchases' page 2022-04-07 14:28:12 -04:00
listBlocked Better non-clickable implementation 2022-04-05 19:44:09 -07:00
lists MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
livestream Refactor and fix websocket connection behavior 2022-04-29 10:43:30 -04:00
livestreamCurrent Add 'ENABLE_WIP_FEATURES' for live page. 2021-08-12 21:52:58 -07:00
livestreamSetup livestream new api 2022-04-20 15:53:28 -04:00
navigationHistory refactor lbrytv web server 2019-11-11 13:27:29 -05:00
notifications Notifications: use fetched urls instead of resolving (#820) 2022-02-07 15:59:20 -05:00
odyseeMembership Clean up @odysee membership channel definition 2022-05-23 10:53:24 +08:00
ownComments Fix missing uri param for fetchReplies 2022-04-27 08:50:23 -04:00
passwordReset new layout 🕺 2020-09-29 17:12:32 -04:00
passwordSet new layout 🕺 2020-09-29 17:12:32 -04:00
passwordUpdate Move 'update password' into a subpage 2021-08-23 23:45:31 +08:00
playlists improve playlists display (#232) 2021-11-05 21:00:27 -04:00
popoutChatWrapper [Live Chat] Break down componets for Page Layout + Add ability to Pop Out chat window + Hide chat option (#681) 2022-01-14 15:24:16 -05:00
publish Desktop cherry-pick: "7240 Integrate lbry redux and lbryinc" 2021-10-19 20:40:07 +08:00
receive Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
report [Report Page] Fix GitHub URL and improve strings (#340) 2021-11-22 09:32:33 -05:00
reportContent Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
repost Allow direct linking a repost create component 2022-05-03 09:36:25 -04:00
rewards FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
rewardsVerify rewards redirect fix for manually approved users 2020-07-03 13:18:28 -04:00
search Remove Premium+ Tiles when Premium+ is active (#1525) 2022-05-18 20:51:15 +02:00
send Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
settings Render whole app on language change 2022-02-26 13:08:17 -05:00
settingsCreator Add "min channel age" setting 2022-02-23 23:01:57 +08:00
settingsNotifications Browser push notifications (#133) 2021-10-27 10:38:10 -04:00
settingsStripeAccount Design patch 2022-04-25 (#1392) 2022-04-25 10:10:45 +02:00
settingsStripeCard Catch up on string changes 2022-03-31 17:54:20 +08:00
show Show-page: fix "no content found" flicker (#1546) 2022-05-24 06:39:21 -04:00
signIn MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
signInVerify VerifyPage: don't enter Sign Up page on failure 2022-04-06 09:15:45 -04:00
signInWalletPassword get sync password out of signing flow 2020-09-21 14:11:25 -04:00
signUp MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
swap Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
tagsFollowing Clean homepage and export copy/paste issues, (no functional change) 2022-04-08 18:56:17 +08:00
tagsFollowingManage per channel notification settings 2020-11-02 14:13:13 -05:00
top removed remaining refs to PAGES.REPOST 2022-04-12 21:07:40 +08:00
wallet Fix missing txoList when balance is 0 2022-05-05 17:15:36 +08:00
watchHistory Batch-resolve Watch History 2022-05-16 07:57:24 -04:00
youtubeSync i18n updates and fixes (#822) 2022-02-07 13:15:22 -05:00