LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/page
History
infinite-persistence dbb9ee7ac6
PremiumBadge: retrieve membership db internally instead of from parent (#1764) 
* DRY up membership selector

Selectors should be chained up, not copy/pasted.

* PremiumBadge: retrieve membership db internally instead of from parent

## Ticket
1753 odyseeMembershipByUri function causing unnecessary renders

## Issue
While the rendering issue in the ticket is due to the way the props are defined, it also surfaced a prop-drilling issue with PremiumBadge.

Instead of asking the parent for the membership db, it can retrieve from Redux itself. This prevents the prop from polluting 2 levels of components and causing unnecessary renders.

## Approach
- Make `PremiumBadge` accept `uri` like most other components.
- I still leave the `membership` prop as (i.e. parent can still pass it directly). In some cases (e.g. `livestreamComment`, `page/odyseeMembership`), the parent itself needs the same data, so we don't need to derive it twice.
2022-07-01 15:40:06 -04:00
..
backup add wallet sync message on wallet page 2020-02-21 13:42:17 -05:00
buy Fix incorrect usages of I18nMessage 2022-02-18 20:00:36 +08:00
channel PremiumBadge: retrieve membership db internally instead of from parent (#1764) 2022-07-01 15:40:06 -04:00
channelNew Limit channel-creation count from the UI (#886) 2022-02-16 09:14:08 -05:00
channels Another padding adjustment on mobile 2022-06-10 08:45:42 +02:00
channelsFollowing Following Page: fix redundant livestream data passed in 2022-03-21 15:03:47 +08:00
channelsFollowingDiscover MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
channelsFollowingManage bump eslint version (#1640) 2022-06-06 12:19:35 -04:00
checkoutPage Revert "move stuff to web (#6537)" 2021-07-19 10:12:57 -04:00
collection Add requested review changes 2022-05-05 09:42:24 -04:00
creatorDashboard Add channel selector on HeaderMenuButton 2022-05-05 11:24:22 -04:00
discover bump eslint version (#1640) 2022-06-06 12:19:35 -04:00
embedWrapper Change poster-fetch implementation 2022-06-16 15:18:15 -04:00
file Preorder cleanup 2022-06-28 13:36:18 +08:00
fileListDownloaded Re-enable 'Purchases' page 2022-04-07 14:28:12 -04:00
fileListPublished Revert "Fix uploads page cleared/reloaded on each navigation" (#1771) 2022-06-29 08:04:33 -04:00
fourOhFour Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
help Add token to help page (internal) (#1737) 2022-06-22 12:32:17 -04:00
home Revert "Fix ads near recommended on Premium" 2022-05-30 14:15:27 +08:00
invite Defer user/invite_status from startup 2022-01-21 09:19:17 -05:00
invited Fix url selectors 2021-11-17 19:57:04 +08:00
library Re-enable 'Purchases' page 2022-04-07 14:28:12 -04:00
listBlocked Better non-clickable implementation 2022-04-05 19:44:09 -07:00
lists MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
livestream Bugfix live status state (#1689) 2022-06-14 09:33:56 -04:00
livestreamCurrent Add 'ENABLE_WIP_FEATURES' for live page. 2021-08-12 21:52:58 -07:00
livestreamSetup livestream new api 2022-04-20 15:53:28 -04:00
navigationHistory refactor lbrytv web server 2019-11-11 13:27:29 -05:00
notifications Notifications: use fetched urls instead of resolving (#820) 2022-02-07 15:59:20 -05:00
odyseeMembership PremiumBadge: retrieve membership db internally instead of from parent (#1764) 2022-07-01 15:40:06 -04:00
ownComments Fix missing uri param for fetchReplies 2022-04-27 08:50:23 -04:00
passwordReset new layout 🕺 2020-09-29 17:12:32 -04:00
passwordSet new layout 🕺 2020-09-29 17:12:32 -04:00
passwordUpdate Move 'update password' into a subpage 2021-08-23 23:45:31 +08:00
playlists improve playlists display (#232) 2021-11-05 21:00:27 -04:00
popoutChatWrapper [Live Chat] Break down componets for Page Layout + Add ability to Pop Out chat window + Hide chat option (#681) 2022-01-14 15:24:16 -05:00
publish Publish revamp (Part 1) (#1593) 2022-06-03 09:28:12 -04:00
receive Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
report [Report Page] Fix GitHub URL and improve strings (#340) 2021-11-22 09:32:33 -05:00
reportContent ReportContent: redirect back after logging in (#1733) 2022-06-22 09:07:15 -04:00
repost Allow direct linking a repost create component 2022-05-03 09:36:25 -04:00
rewards FAQ stuff (#109) 2021-10-21 16:21:51 -04:00
rewardsVerify rewards redirect fix for manually approved users 2020-07-03 13:18:28 -04:00
search Remove Premium+ Tiles when Premium+ is active (#1525) 2022-05-18 20:51:15 +02:00
send Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
settings Render whole app on language change 2022-02-26 13:08:17 -05:00
settingsCreator Add "min channel age" setting 2022-02-23 23:01:57 +08:00
settingsNotifications Browser push notifications (#133) 2021-10-27 10:38:10 -04:00
settingsStripeAccount Design patch 2022-04-25 (#1392) 2022-04-25 10:10:45 +02:00
settingsStripeCard Allow capture of name during adding of card (#1657) 2022-06-14 09:21:47 -04:00
show Don't block entire router while fetching Categories 2022-06-02 14:11:52 +08:00
signIn MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
signInVerify bump eslint version (#1640) 2022-06-06 12:19:35 -04:00
signInWalletPassword get sync password out of signing flow 2020-09-21 14:11:25 -04:00
signUp MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
swap Don't connect to the Redux store when not needed. 2021-10-24 13:04:01 +08:00
tagsFollowing Clean homepage and export copy/paste issues, (no functional change) 2022-04-08 18:56:17 +08:00
tagsFollowingManage per channel notification settings 2020-11-02 14:13:13 -05:00
top removed remaining refs to PAGES.REPOST 2022-04-12 21:07:40 +08:00
wallet Fix missing txoList when balance is 0 2022-05-05 17:15:36 +08:00
watchHistory Batch-resolve Watch History 2022-05-16 07:57:24 -04:00
youtubeSync Str and cleanup 2022-06-22 20:53:34 +08:00