Commit graph

1972 commits

Author SHA1 Message Date
btzr-io c0c65c46f4 use env for twitter account 2021-08-01 09:39:16 -04:00
btzr-io d462f96834 improve twitter share 2021-08-01 09:39:16 -04:00
Baltazar Gomez 37d9cbfbeb limit claim_search results on livestreamLink 2021-08-01 09:13:25 -04:00
btzr-io 9983777f86 faster claim search on livestreamLink 2021-08-01 09:13:25 -04:00
btzr-io 7802337655 prevent livestream api calls if no livestream claim exists: #6632 2021-08-01 09:13:25 -04:00
Thomas Zarebczan b5fec393c6
Fix crash 2021-07-31 11:08:15 -04:00
zeppi b93caf4ebc fix logo image 2021-07-30 12:12:58 -04:00
saltrafael 87ae041472 Add confirmation on comment removal 2021-07-30 10:24:04 -04:00
Baltazar Gomez 415a522805 fix notification menu button styles 2021-07-30 00:11:18 -07:00
infinite-persistence 0cdf881941
#6470 Improve accessibility and some minor css fixes 2021-07-30 09:34:40 +08:00
saltrafael cc93ac1a01 Fix currently active playing item on playlist 2021-07-29 14:55:52 -04:00
infinite-persistence 7537b5ae7b
Lint and cleanup. No functional change. 2021-07-29 21:11:20 +08:00
infinite-persistence 4ff32e0c61
Fix missing file-thumbnail in Notifications
## Issue
6721 Notifications: Thumbnail for "new content" not showing up in Desktop layout

## Change
The `className` wasn't propagated during the `FileThumbnail` refactoring to `Thumbs`.
2021-07-29 15:56:42 +08:00
Baltazar Gomez 74087d2b86
Merge branch 'master' into accessibility 2021-07-28 23:47:42 -05:00
zeppi 9889c258e3 livestream api constant rename 2021-07-28 16:51:11 -04:00
zeppi d25896d99c recon commentCreate 2021-07-28 15:43:56 -04:00
zeppi edebde5a2e file reactions recon 2021-07-28 08:12:29 -04:00
zeppi 2a69c42e5b back to img tag 2021-07-27 15:13:29 -04:00
zeppi b1e8d2d6db desktop logo 2021-07-27 15:13:29 -04:00
zeppi ef77a5cd00 optimizedImage 2021-07-27 15:13:29 -04:00
zeppi 71d9b0d973 default logo 2021-07-27 15:13:29 -04:00
zeppi 3f4c601428 logo component on embeds/embeds ended 2021-07-27 15:13:29 -04:00
zeppi 19f8b0adac logoComponent 2021-07-27 15:13:29 -04:00
zeppi e4d7e4f69d force has source channel page 2021-07-26 14:17:52 -04:00
zeppi 403ea8f6f4 no livestreams on channel content 2021-07-26 14:17:52 -04:00
infinite-persistence 6de16813cb
i18n update 2021-07-26 23:31:03 +08:00
infinite-persistence 8dc18e8fcd
Fix split (concat) string usage
Concatenated strings are hard to translate.
2021-07-26 12:37:59 +08:00
zeppi 0987c6e94f publish form recon 2021-07-23 10:14:22 -04:00
infinite-persistence ffad52d5b7 Remove console.log
Seems like lint is being bypassed recently?
2021-07-23 08:42:58 -04:00
infinite-persistence 7a8d213861
Eliminate CLS in Recommended due to wrapper mismatch
Seem like `type === small` was missed out, so it was using a wrapper than necessary, causing the shift.
2021-07-23 13:23:52 +08:00
zeppi 038431f95c channel follow first run on master 2021-07-23 00:00:32 -04:00
zeppi ed0387d94a pinning 2021-07-22 23:24:55 -04:00
zeppi d88752c646 music icon, fix lint 2021-07-22 17:31:46 -04:00
Anthony 78b4fa05b3 pull out variable for max and min fiat amounts 2021-07-22 14:06:59 -04:00
Anthony 7975ccf3e0 disable button if theres a fiat tip error 2021-07-22 14:06:59 -04:00
Anthony 713dc69ed7 add check for two decimals and fix showing error for fiat tip 2021-07-22 14:06:59 -04:00
zeppi f4559c1cce fileSubtitle recon 2021-07-22 12:09:54 -04:00
zeppi 8919182c0c default avatar config 2021-07-22 09:44:57 -04:00
btzr-io 86e1cfc3dd refactoring of claim preview aria-label format 2021-07-22 03:24:25 -05:00
btzr-io 2a291366da use full sentences with variables for claim preview aria-label 2021-07-22 02:37:57 -05:00
infinite-persistence 032e17cecd
Improve CLS on Posts
## Issue
6068 Fix "Cumulative Layout Shift" for Core Web Vitals

In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores.

## Approach
There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay.

## Changes
- Posts: Add 2s fade-in delay to Comments.
- Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient.
- Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1.
2021-07-22 10:38:01 +08:00
Baltazar Gomez c983af927f
Merge branch 'master' into accessibility 2021-07-21 20:59:12 -05:00
infinite-persistence 50c606d916 claimListDiscover: don't re-render until query is done
## Issue
6542 Livestream listing and blocked list kills CLS score

This is basically a repeat of what was done on `claimTileDiscover` (homepage), but now on `claimListDiscover` (category pages).

This handles the unnecessary re-render when:
- the uri list temporarily being zero while waiting for new claim-search results.
- livestream claim-search invalidating the list.

## Changes
Store the last uri list and use that when we know that claim-search is still not done.

## Tests
1. Ran Lighthouse on category pages (force a livestream channel on it). CLS score must be green.
2. Block `claim_search` from Dev Tools and move to another category. The page should say "timed out" instead of "no results" (i.e. maintain existing behavior).
2021-07-21 21:51:12 -04:00
zeppi 1994b5da04 guidelines optional in sidenav 2021-07-21 20:26:17 -04:00
zeppi fbf105e113 fileActions recon 2021-07-21 18:37:43 -04:00
zeppi 91b908ad50 pubfile copy 2021-07-21 16:18:46 -04:00
infinite-persistence 4fc6b89975 Fix reposted channels incorrectly showing the channel thumb
## Issue
6589

## Notes
`parseURI` will return `isChannel=false` due to the reposted channel URL not having the '@' symbol.

Since we already have the claim object, check `value_type` directly instead.
2021-07-21 14:41:47 -04:00
saltrafael b164a5d1f4 Pop up Menu Fixes and Improvements
Pop up Menu Fixes and Improvements

Improve re-directs

Fix file deletion

Improve code, and more

Fix List Layout collection popup

Allow to edit list

Fix blocking when not logged or no channel

Fix Edit and Delete showing for not owned Lists

Fix actions breaking when not logged in

Fix List options not showing

Lint

Shorten logic

Lint
2021-07-21 14:40:44 -04:00
zeppi fdca58727c restore paid content 2021-07-21 12:49:56 -04:00
zeppi 1600bb69b9 sms copy 2021-07-21 08:11:33 -04:00
infinite-persistence 6b2548cc49
Fix channel-selector thumbnail not updating
Recently changed to `<OptimizedImg>`, which was assuming the `src` never changes.

dejavu ... we also hit this issue when implementing the `IntersectionObserver` lazy-loading.
2021-07-21 16:38:54 +08:00
btzr-io 6a8d32c9bf add SkipNavigationButton to its own file 2021-07-20 19:31:26 -05:00
btzr-io f6261611f0 fix ClaimPreview errors 2021-07-20 18:49:41 -05:00
Dispatch e138673d27
Merge pull request #6508 from saltrafael/live_comments
Fix 'Recent Comments' button for livestreams
2021-07-20 12:33:52 -07:00
zeppi 283bbb52fa disable google imasdk 2021-07-20 15:12:14 -04:00
zeppi 8674b97be8 disable aniview 2021-07-20 15:12:14 -04:00
Baltazar Gomez 0db4e4ab51
Merge branch 'master' into accessibility 2021-07-20 12:24:36 -05:00
btzr-io bc2a8ba77d fix accessibility issue on rewards page #5991 2021-07-20 12:14:28 -05:00
zeppi e4f1d4221b header notify recon 2021-07-20 12:32:17 -04:00
zeppi 8301244507 commentReactions recon ma 2021-07-20 11:17:44 -04:00
zeppi 27400cbe03 yt recon 2021-07-20 10:37:46 -04:00
zeppi e834a4aa51 change uploads copy 2021-07-20 10:33:48 -04:00
infinite-persistence 11b5eb49a0
Optimize ChannelThumbnail using the new method 2021-07-20 16:21:51 +08:00
infinite-persistence 68432eef26
OptimizedImage - wrapper for CDN-optimized image
Objective:
- Get appropriately sized images to improve performance and Core Vitals score.
- Ensure images using "objectFit=cover" doesn't get stretched out if the source is large enough.
- Peg to 100px increments for better caching.

Notes:
- Skip images hosted in '/public'. If we really want to optimize it, then we'll need to provide the full path in the code, otherwise CDN lookup will fail.
2021-07-20 16:21:50 +08:00
infinite-persistence 08738ffcee
Reaction-fetch: handle "deleted all channels"
- use `selectActiveChannelClaim` as that takes the current channel list into account (i.e. correct state when all channels are deleted).
    - `selectActiveChannelId` should probably be removed or not exposed through a selector, as it is not updated when channel list changes?
2021-07-20 15:22:50 +08:00
infinite-persistence c71e4718d0
Remove (revert) reaction-fetch hardstop
Root-cause is known, so removing it to detect other issues.
2021-07-20 15:22:49 +08:00
zeppi 4bf7c68574 use config for showTagsIntro 2021-07-19 22:46:43 -04:00
zeppi 765cef7564 recon notify components 2021-07-19 22:16:29 -04:00
zeppi 3dc7c35cd7 recon 2021-07-19 21:46:28 -04:00
zeppi f6dc48fdc0 use odysee recsys plugin 2021-07-19 17:30:44 -04:00
zeppi 26e67b375c more 2021-07-19 13:52:15 -04:00
zeppi 50875566ad more 2021-07-19 13:52:15 -04:00
Anthony fdfa2f1660 hotfix for bug 2021-07-19 11:08:59 -04:00
jessopb ae2354a0e0 Revert "move stuff to web (#6537)"
This reverts commit a6c413da5c.
2021-07-19 10:12:57 -04:00
infinite-persistence 6f4ce0a57c
Apply placeholder images
https://lbryians.slack.com/archives/C81FGKR51/p1624278721203900?thread_ts=1624269131.202200&cid=C81FGKR51

The intrinsic size needs to be at least equal the final image's size. Stretching, SVGs, etc. doesn't count.
2021-07-19 12:07:26 +08:00
zeppi e03325d0e4 remove old stripe setting 2021-07-18 22:30:12 -04:00
jessopb a6c413da5c
move stuff to web (#6537) 2021-07-18 21:57:36 -04:00
mayeaux 4fe17363f3
disable review button if no card saved also some cleanup (#6535)
* disable review button if no card saved also some cleanup

* fix flow errors
2021-07-18 21:49:21 -04:00
jessopb 5a04d0fea0
some recon (#6532) 2021-07-18 13:06:52 -04:00
zeppi dfc013d423 more recon 2021-07-18 11:27:05 -04:00
infinite-persistence 1fa7533ee3
Hide 'download' for livestreams
6517
2021-07-18 23:10:59 +08:00
infinite-persistence f3ed597ff6
i18n: Fix invalid template literal use + split strings 2021-07-18 22:42:21 +08:00
Anthony 6aea8e38bc fix css 2021-07-17 13:19:33 -04:00
zeppi 7ffd59c169 more lint 2021-07-17 13:19:33 -04:00
zeppi 27aa4e4a22 lint 2021-07-17 13:19:33 -04:00
Anthony 7bb5df97fd Stripe 2
show visible card and add remove card button

show your transactions even if you dont have a card

fix presentational issues

show your transactions even if you dont have a card

fix presentational issues

add link to channel section

update yarn

show donation location

add remove card modal still needs completion and also changed how stripe is used on settings stripe card page

add confirm remove card modal to router

move bank account stuff to settings page

move account functionality to settings page

continuing to move account transactions to settings

list transactions for creator

updating copy

touchup tip error

do a better job autofocusing

bugfix

show an error on the card page if api returns 500

building out frontend for comment tip

display dollar sign if its a fiat tip

more frontend work

more frontend work

more frontend bug fixes

working with hardcoded payment intent id

working but with one bug

bugfixed

add toast if payment fails

add add card button

cant get claim id but otherwise done

more frontend work

call is working

show fiat for livestream comments

add is fiat on comments

round and show values properly

dont allow review if tiperror

copy displaying properly

disable buttons conditionally properly

remove card button working

remove card working with a workaround by refreshing page

bugfix

send toast when tip on comment

jeremy frontend changes

only show cart on lbc
2021-07-17 13:19:33 -04:00
infinite-persistence cd32fb71c7
Experiment: hardstop reaction-fetch at 500
(Hypothetical max comment of 3000) / (10 comments per page) = 300.
Cap at 500 to stop runnaway loops.
2021-07-17 22:19:15 +08:00
infinite-persistence 47d39b20d3
Stop fetching reacts if failed for 3 times
Not sure if this will ever occur, but technically possible from the code point of view. Try adding this to see if it stops the spikes in `reaction.list` calls.
2021-07-17 13:53:58 +08:00
infinite-persistence 9c05239b04
Don't show "comments disabled" while still fetching.
## Issue
6513
2021-07-17 12:09:42 +08:00
keikari 1882e78d51 Tried to clear errors mentioned in lint details
154:28  error    Trailing spaces not allowed     
 161:6   error    Unexpected tab character
2021-07-16 18:32:41 -04:00
keikari 299682a6dc Make "support-pop-up" text match claim type.
Confirm button label will also show "your" instead of "this" for your own claims.
2021-07-16 18:32:41 -04:00
keikari 08dd1cbf0b Minor fix suggestion: Default to "TAB_BOOST" when supporting own claims
Someone mentioned about odysee.com showing "tip" related text when supporting own claim. Now it should default to "Boost" related text for own claims.

L167: Not edited but not sure if "claimIsMine" is needed there any more.
2021-07-16 18:32:41 -04:00
zeppi 70af46149d discover channelIds from homepages 2021-07-16 18:31:48 -04:00
saltrafael 9cdfb239c0
Playlist style fixes (#6509)
* Fix spacing on List page

* Fix alignment on List sidebar
2021-07-16 15:13:28 -04:00
Baltazar Gomez e59c67a144
render filedrop for only authenticated users (#6466) 2021-07-16 14:53:14 -04:00
Marko Lorentz e44b7b929e
i18n: Added missing state handling for RTL languages (#6275)
* Add RTL Support

* Add Arabic to supportedLanguages

* Fixed lint errors

* Allowed RTL flow for Hebrew

Co-authored-by: Sana <sana.benhassouna@ensi-uma.tn>
2021-07-16 13:51:08 -04:00
btzr-io 4d28c5d208 use aria current 2021-07-16 10:58:40 -04:00
btzr-io 504f230d59 show currently active playing item on playlist: #6204 2021-07-16 10:58:40 -04:00
infinite-persistence ad7db1e939 Reactions: wait for previous fetch to complete before fetching again.
This was causing duplicate IDs to be fetched over and over again when scrolling quickly.
2021-07-16 10:54:12 -04:00
infinite-persistence a13708f4dd Handle the case of all replies are blocked.
In this scenario, `comment.List` does not return `comment`. I was expecting an empty array.

Handled accordingly.
2021-07-16 10:54:12 -04:00