LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity
lbry-desktop/ui/scss/component
History
infinite-persistence fc50095b36 Make notification titles translatable 
## Issue
Desktop 7022: i18n: Notification title localization lost

## Approach
The current code breaks up the string into an array of strings, so i18n is somewhat impossible.

Since 99%¹ of dynamic notifications come with a `dynamic` property for all the replaceable values, we can actually reconstruct the string however we want.

¹ <sub>_as far as I can find, only `fiat_tip` does not provide the value via `dynamic`, i.e. hardcoded in the string. Boo._</sub>

### Benefits of this approach:
- able to localize the string again
- able to customize the string (e.g. making claim titles italic, fix typos, use more concise strings, etc.)

### Problems with this approach:
- if the api overloads a particular notification type with several strings, then the approach is broken.
    - Ex. For the case of `comment` type, the overload is whether the comment is a normal comment or hyperchat. But I was able to replicate the logic to differentiate them, so all is good.
    - For the case of "livestream reminder in 30 minutes", we would have to inspect the string to differentiate against "is live streaming". I think this reminder is not being used, so I didn't do it yet.
- some work is needed to maintain the code when the server side updates something.  But we are already manually maintaining the i18n strings anyway, so it shouldn't be too much of a burden.
- With the exception of the overload problem, any new notification type will simply pass through as un-localized, so things should continue to work, i.e. no need to update the front-end immediately 🤞
2022-04-07 12:30:07 -04:00
..
_ads.scss Add outbrain 2022-03-18 14:32:55 -04:00
_animation.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_badge.scss theme orginization and cleanup 2021-04-30 15:05:58 -04:00
_block-list.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_button.scss Membership subscriptions (#812) 2022-03-09 13:05:37 -05:00
_calendar.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_card.scss Medium-layout: more "comment section collapse" fixes 2022-04-07 13:14:49 +08:00
_channel-mention.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_channel.scss Design fallout patch 2 (#1245) 2022-03-30 17:53:05 +02:00
_claim-list.scss Design patch 7 (#1286) 2022-04-05 16:59:38 +02:00
_claim-search.scss Design fallout patch 2 (#1245) 2022-03-30 17:53:05 +02:00
_claim_support_button.scss patch 3 (#1251) 2022-03-31 11:19:32 +02:00
_collection.scss Fix design & UI issues (#1056) 2022-03-09 14:21:18 +01:00
_color-picker.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_comment-badge.scss Various touchups/fixes of membership functionality (#1066) 2022-03-14 22:38:45 -04:00
_comment-create.scss Adjust input focus in reply 2022-02-18 08:50:49 +01:00
_comment-selectors.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_comments.scss Medium-layout: more "comment section collapse" fixes 2022-04-07 13:14:49 +08:00
_content.scss Add dynamic player aspect ratio resizing 2022-04-07 11:44:25 -04:00
_dat-gui.scss Fix and enable 3D viewer: #4035 2020-04-27 14:27:04 -04:00
_embed-player.scss Fix post-editor preview mode 2022-04-01 12:36:49 -04:00
_emote-selector.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_empty.scss winning claim style pass 2020-12-16 14:58:30 -05:00
_expandable.scss Fix warnings 2022-03-23 17:09:17 -04:00
_file-drop.scss Paste/drop images directly to markdown editor 2022-04-01 12:36:49 -04:00
_file-list.scss moonpay 2020-06-03 14:16:43 -04:00
_file-price.scss Design patch 6 (#1285) 2022-04-05 16:02:32 +02:00
_file-properties.scss unify some styles with master 2021-04-27 11:20:41 -04:00
_file-render.scss Add dynamic player aspect ratio resizing 2022-04-07 11:44:25 -04:00
_footer.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_form-field.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_form-row.scss moonpay 2020-06-03 14:16:43 -04:00
_header.scss Align premium badge in header 2022-03-09 22:28:37 +01:00
_icon.scss Add hint that results are being filtered by language 2022-02-25 16:53:45 -05:00
_item-list.scss moonpay 2020-06-03 14:16:43 -04:00
_livestream-chat.scss Design fallout patch 2 (#1245) 2022-03-30 17:53:05 +02:00
_livestream-comment.scss Fix external link icon size in livestream chat 2022-03-18 11:18:31 +01:00
_livestream.scss Category livestreams: re-implement using subSection + use horizontal scroll in mobile 2022-03-01 10:27:09 -05:00
_main.scss Add dynamic player aspect ratio resizing 2022-04-07 11:44:25 -04:00
_markdown-editor.scss Paste/drop images directly to markdown editor 2022-04-01 12:36:49 -04:00
_markdown-preview.scss patch 3 (#1251) 2022-03-31 11:19:32 +02:00
_media.scss Design patch 7 (#1286) 2022-04-05 16:59:38 +02:00
_membership.scss patch 3 (#1251) 2022-03-31 11:19:32 +02:00
_meme.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_modal.scss Design patch 6 (#1285) 2022-04-05 16:02:32 +02:00
_navigation.scss Sidebar: handle stray separator on empty section 2022-03-21 22:52:38 -07:00
_notification.scss Make notification titles translatable 2022-04-07 12:30:07 -04:00
_nudge.scss patch 3 (#1251) 2022-03-31 11:19:32 +02:00
_pagination.scss Fix Paginate click area 2022-04-04 08:40:41 -04:00
_placeholder.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_post.scss Adjust comment section width on markdown page on HiDPI screens 2022-02-18 09:23:47 +01:00
_progress.scss add youtube sync to first run 2020-09-29 17:12:32 -04:00
_purchase.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_search.scss Fix repost ribbon on search result page 2022-02-18 12:56:03 +01:00
_share.scss use web share api 2020-03-30 15:49:45 -04:00
_snack-bar.scss Sub-message was hard to read for non-error toasts 2022-03-24 16:16:53 +08:00
_spinner.scss ClaimList: add default page-load indicator | Apply for Search and Following-Manage 2022-03-02 09:16:43 -05:00
_splash.scss bold more text in popup dialog 2022-03-28 15:30:36 -04:00
_status-bar.scss Fix css "--spacing-?" renaming that recent PRs missed during the merge. 2020-06-04 10:53:32 -04:00
_sticker-selector.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_stripe-card.scss use BEM 2022-03-29 12:23:20 -04:00
_superchat.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_swipe-list.scss Add horizontal layout (#636) 2022-01-06 16:13:26 -05:00
_swipeable-drawer.scss Add dynamic player aspect ratio resizing 2022-04-07 11:44:25 -04:00
_syntax-highlighter.scss Add integrated light theme 2020-02-07 09:21:28 -05:00
_table.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_tags.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_textarea-suggestions.scss Realign stars in channel level indicator 2022-02-14 16:28:24 +01:00
_tooltip.scss Membership subscriptions (#812) 2022-03-09 13:05:37 -05:00
_txo-list.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_utils.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_videojs.scss Add dynamic player aspect ratio resizing 2022-04-07 11:44:25 -04:00
_view_count.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_wallet-tip-selector.scss [New Feature] Stickers (#131) 2021-10-28 16:25:34 -04:00
_wallet-tip-send.scss improve tip support functionality 2022-03-28 15:30:36 -04:00
_wunderbar.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
_yrbl.scss New repost flow 2020-12-16 09:47:28 -05:00
claim-preview-reset.scss Fixed vars.scss being imported multiple times (#528) 2021-12-20 20:27:25 -05:00
expanding-details.scss moonpay 2020-06-03 14:16:43 -04:00
homepage-sort.scss Fix element position when dragged in homepage customizer 2022-04-03 15:19:05 +02:00
livestream-scheduled-info.scss Feature livestream scheduling (#458) 2021-12-16 16:59:13 -05:00
menu-button.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
nag.scss Use locale/get response to suggest homepage and language switch (#839) 2022-03-02 09:44:01 -05:00
notifications-banner.scss Fixed vars.scss being imported multiple times (#528) 2021-12-20 20:27:25 -05:00
notifications-blocked.scss MAKE ODYSEE EVEN MORE BEAUTIFUL (#539) 2022-02-11 13:50:55 -05:00
section.scss patch 5 (#1279) 2022-04-04 17:43:10 +02:00
tabs.scss Adjust active tab indicator 2022-02-14 11:48:55 +01:00