7cbb7a54aa
* Remove ad-handling in videojs.jsx Primary impetus is to remove unnecessary IntersectionObserver usage, but it should be removed anyway because: - no longer relevant today with Adnimation's script. - we also globally hide floating ads now, so no more invisible divs. - the code is wrongly placed -- it's not the responsibility of the Videojs component. * use-lazy-loaded: skip if IntersectionObserver is not supported ## Issue Page not loading in older Safari (e.g. ipad air 2) ## Approach Instead of using a polyfill (which comes with implementation caveats), just not apply the lazy-loading for those old browsers. Not lazy-loading is better than not loading at all, plus this is way easier to test (even by just reading the code) than testing out the polyfill implementation's caveats. The cons is we would need the polyfill if we use it in other places in the future. ## Code Changes Factor out the src-setting code, and use it directly when IntersectionObserver is not found. |
||
|---|---|---|
| .. | ||
| effects | ||
| plugins | ||
| ads.js | ||
| chapters.jsx | ||
| chromecast.js | ||
| lbry-playback-rate.js | ||
| lbry-volume-bar.js | ||
| overlays.js | ||
| play-next.js | ||
| play-previous.js | ||
| videojs-events.jsx | ||
| videojs-functions.jsx | ||
| videojs-shortcuts.jsx | ||
| videojs.jsx | ||